Bug Fixes For Mobile and More

[Moneycito]

@sujato

Back to the main job, how are we going with things? I’ve been pretty much distracted these past few days. I think the relevant bugs are squashed, is that right?

Hi @sujato and @blake ,

Sorry, I had some distractions as well over the last few days. Back in the saddle here now and here is where we stand:

The bug regarding the disappearing header does seem to be fixed, but the first thing I will be looking into this morning will be how it was fixed and if my changes were incorporated from staging back into Master. There was a message in this thread regarding a “stab in the dark” by Blake to fix things and that may or may not have been using the code that I wrote in the branch. I will see if I can get a hold of @blake to confirm/determine where we stand with all of that integration stuff.

I still need to look into these other bugs you mentioned:

@sujato

Also, another small detail for you. The look and behavior of the triangles that we use in the sidebar is not consistent.

See a page such as SuttaCentral

Compare the “Languages” button under “Navigation” with “Lookup Language” under “Tools”. The latter is incorrect, it should be like the “Languages” button, i.e. with the the triangle before the word, and shifting to a downwards pointing when the dropdown is displayed. Also, ensure that these are all the same size, currently the sizing is inconsistent.

Here is another example of inconsistent sizing: SuttaCentral The triangles should be bigger, about 2em, but without wrecking the line height and other spacing. Also, the popups on these pages have drifted away, they should come up near the triangles, not way off to the side.

And one further bug on this page: very weirdly, the “cite” widget, which should appear below the table, is in the popup in the final row of the table. Compare SuttaCentral, where the cite button appears in the correct place.

These little details just seem to drift if you don’t keep your eye on them.

as well as the search result bugs:

@sujato

there’s another mobile-oriented job i wanted you to look at. That’s the search result pages. They are not too bad, but could probably do with a little mobile optimization.

Dave