Yes! Thank you @sabbamitta, it also works for me. Thank you @HongDa
@carmi, @sabbamitta I just finished translating sn-guide-sujato, and I am proofreading it now. Suddenly, I have a doubt: I should keep the HTML tags in the text, right?
Yes yes, just copy this as is. It’s only the text between the tags, in this case the word “saṁyutta”, that you may translate, if appropriate.
Great, thank you so much for your prompt help.
@carmi, thank you for your help on publishing sn-guide-sujato_translation-fr-site. Something got included in the page which I don’t think belongs there.
That is a problem with the ToC which the devs need to solve. As far as I know they are aware of it, but didn’t get around to do it so far. @HongDa?
(The title for the six sense fields has originally been forgotten in the ToC, and later been added without full success.)
But make sure that all ToC links point to the right topis—this is your part to fix (see here; you may compare with the German under sn-guide-sujato_translation-de-site
in Bilara).
Ah yes. Sorry, I missed that post where you mentioned it. I think the ToC links in the French translation point to the right topics, but I do see a difference with the German one:
Yes, that’s exactly it. Item #5 is the one that has been added, the six sense fields; but it is not represented in Bilara. The ToC previously had one item less. If you click on the website on what has now #5
in your ToC, the link will take you to item #5 on the “real site”, which is the six sense fields, and not the Mahavagga. The same for the following link. Try it out.
So you must replace the #5 in your ToC by a #6, and the #6 by a #7, so that these links will at least point to what the titles say. For the six sense fields there is currently no link. (Just imagine that a 5th item will be added in Bilara between #4 and #6—which is now wrongly called #5.)
In English this hasn’t been fixed, which is why it is misleading for all following translators.
OK, thank you, I’ll update this soon, I want to make a few changes to the other guides too, so I’ll post all these together.
To fix this issue, modifications need to be made to the sn-guide-sujato.json
file for each language version, for example:
"sn-guide-sujato:6": "<a href='#item4'>The Book of the Aggregates</a>",
"sn-guide-sujato:7": "<a href='#item6'>The Great Book</a>",
became:
"sn-guide-sujato:6": "<a href='#item4'>The Book of the Aggregates</a>",
"sn-guide-sujato:6.1": "<a href='#item5'>The Book of the Six Sense Fields</a>",
"sn-guide-sujato:7": "<a href='#item6'>The Great Book</a>",
another example:
https://github.com/suttacentral/bilara-data/blob/published/translation/de/site/sn-guide-sujato_translation-de-site.json
"sn-guide-sujato:6": "<a href='#item4'>Das Buch der Aggregate</a> ",
"sn-guide-sujato:7": "<a href='#item6'>Das Große Buch</a> ",
became:
"sn-guide-sujato:6": "<a href='#item4'>Das Buch der Aggregate</a> ",
"sn-guide-sujato:6.1": "<a href='#item5'>Das Buch der sechs Sinnesfelder</a>",
"sn-guide-sujato:7": "<a href='#item6'>Das Große Buch</a> ",
Should we translators make the respective pull requests and propose you for checking and merging? Can not simply a line be added to Bilara, so that also future translators can translate it?
I can directly modify the German version first, and then you can see if it can be displayed normally in bilara
Let’s try that, thank you!
I have modified this file, please check it when you have time, and I translated it by machine, I don’t know if it is accurate, please check it.
Looks good, thank you.
Perfect! The same title appears further down in the same file, line 167 in the json file.
The “Master of German” award is for you!
It is expected that I will update the staging tomorrow, and then I will see if the modification results are correct.
I can make the respective pull request for French too, so both can go to the site together.
@HongDa, I have just created a pull request for French, but it says it has merge conflicts.
Okay, done:
added:
"sn-guide-sujato:6.1": "<a href='#item5'>Le Livre des Six Champs Sensoriels</a>",
It seems we both tried to do it at the same time, so I’ll close my pull request. Done.
@HongDa, and Bhante @sujato, the change made in the issue #2603 that you (HongDa) posted above has been merged into master
on suttacentral/suttacentral
three weeks ago, in a file called client/localization/elements/sn-guide-sujato_en.json
.
But the change is not in bilara-data unpublished
, nor is it in bilara-data published
; it seems not to be in bilara-data at all—perhaps this is the reason why it doesn’t appear in Bilara, and why it looks so wrong on the website?