Nice! I’m really liking this direction. The main functionality seems to work great, I’ve tried dozens of pages and they all seem fine, although I haven’t tested the data as such.
it’s actually really cool to be able to switch between details pages, I can’t believe we haven’t done this before!
Here’s some details to have a look at:
The new tables aren’t picking up “partially parallels”, but just represents them as ordinary parallels.- As for the long bookmarks, in most cases the form these are in is just placeholder and should be changed. The most obvious cases are “t-linehead”, which should be removed, and “verse-num-sc” which should be replaced with “verse”. vagga-gatha-num should also be replaced, not sure what with.
- In some cases, the long bookmarks are due to the genuine complexity of the publishing history of the original material. I’m thinking of the Skt Mu-Sarv Vinaya, for which we have say : Skt Mu Kd 17 #sbvi128-#sbvi136. Such cases should be retained.
- One detail that just came up with Ayya Vimala. When looking at the new display, it’s not immediately obvious what the difference is between the “whole text parallels”, which appear at the top, and the verse, etc. parallels, i.e. the ones with bookmarks, which appear underneath. perhaps we should have some way of labelling them, but if so, what? We have to avoid confusion with the concept of “partial parallel” …
- For some reason I’m not seeing the text button for certain texts. On SuttaCentral for example, neithe Dhp nor Divy show any texts.
- Clicking on the text link for bookmarked texts should go to the bookmarked URL, instead they just go to the generic URL.
- I assume you know, but anyway the translation dropdown isn’t working; and also, the title attribute for it is wrong.
- The CSS for the “connector” breaks on “is mentioned in” in some tables and scale sizes. It also breaks at narrow page sizes. The connector obviously needs adjustment, perhaps you have some idea for a more robust approach here.
- SuttaCentral is an interesting case: as a “range”, it doesn’t have a title.
- I’m thinking we should adjust the display of the bookmarks. Treat the hashed portion like the secondary text, (font-size: 0.8rem; color: #767676), and not have a space before the hash. Oh, and use en-dashes!
- It’s also time we can do something similar with the alternative titles we find In Pali, perhaps elsewhere. Instead of
Vekhanassa [Vekhanasa]
we should have something likeVekhanassa <span class="alt-title" style="font-size: 0.8rem; color: #767676; display:block" title="Alternative title">Vekhanasa</span>
- Meanwhile, the vertical alignment needs attention. I’m not sure of the most elegant way to do this in CSS. But typographically speaking:
- In the main “related” section, the top line should all sit on the same baseline (i.e. .root-id, the title (which BTW should have a class, I guess), and the vol/page.)
- The line-height for the tables should be reduced to 1.25. This keeps the info connected, so that whitespace is separating things.
- The target region for .root-id shouldn’t fill the horizontal space. It should be a button. This can be achieved using
display:table-cell
, although this further borks the vertical alignment. Nevertheless, we should find a CSS solution for this than add more divs. I’ve made a hacky version that works okay in most places, but it breaks in some contexts and is not the best solution. - Load this bad boy up: SuttaCentral I’ll have a coffee and get back when it renders. Display per verse instead. (Full div optionally?) This applies to all the Dhammapadas. While we’re on the topic, we should probably use “Pali Dhammapada” as the dhp title. the ID can stay the same, as it is commonly used.
- Having said which, the performance generally is great. On pingdom, I’m getting load times under 500ms in the US.
- getting even pettier: you’ve simplified the borders, but that creates a “notch” where the rounded corners meet. We need to use the more complex form.
- I’ve more and more come to see that we need a divider between ID and title in captions and headings. And, contra my previous opinions, this should be a colon. Luckily it’s easy to add with an :after.
- In cases where there is no text, we currently display the “button”, with a title saying “no text available”. Would it not be better to just not have the button?
- Some pages return a 500 error: SuttaCentral
Anyway, here’s the CSS overrides that mostly do what I want. Again, this just a demo, I’m sure there are more elegant solutions.
relationships_table_overrides.css.zip (634 Bytes)